fix(snapshot): Change to ignore all link[rel="modulepreload"] (#228)
#1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac9f15b The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
billyvg
commented
Dec 17, 2024
| ) { | ||
| // ignore | ||
| } else if ( | ||
| tagName === 'link' && | ||
| n.attributes.rel === 'prefetch' && | ||
| typeof n.attributes.href === 'string' && | ||
| n.attributes.href.endsWith('.js') | ||
| extractFileExtension(n.attributes.href) === 'js' |
There was a problem hiding this comment.
This is what is done in snapshot.ts
... removes requirement to have `as="script"` attribute. Also fixes prefetch to extract file extension instead of checking end of string since there can be URL parameters.
billyvg
force-pushed
the
fix-snapshot-link-modulepreload-ignore-all-up
branch
from
8a91047 to
ac9f15b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... removes requirement to have
as="script"attribute as it is optional (alsomodulepreloadimplies script).Also fixes
prefetchto extract file extension instead of checking end of string since there can be URL parameters.